Search age range #25
Open
Search age range #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| Then(/^a list of age\-filtered profiles is diplayed$/) do | ||
| save_and_open_page |
There was a problem hiding this comment.
fixed now.. thanks!
dmgarland
force-pushed
the
search-age-range
branch
from
006c0de to
9afe826
Compare
| @@ -23,6 +23,15 @@ def search | |||
| if params[:distance] | |||
| @results = @results.near(current_customer.profile.postcode, params[:distance].to_f) | |||
| end | |||
|
|
|||
| if params[:age] | |||
| @results = @results.select do |result| | |||
There was a problem hiding this comment.
Rather than using select, use a where and perform your searches at the DB level
|
@tamlyn10 this needs patching up before I can merge |
tamlyn10
force-pushed
the
search-age-range
branch
from
9afe826 to
83eb471
Compare
dmgarland
force-pushed
the
search-age-range
branch
from
83eb471 to
bdb20ac
Compare
|
Still got some failing tests on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.